search

kmadac / bitstamp-python-client

Python package to communicate with bitstamp.net
MIT License
143 stars 70 forks source link

problem with cancel_order #10

Closed fimdomeio closed 10 years ago

fimdomeio commented 10 years ago

I'm to much of a python noob to have to confidence to submit a patch but cancel_order does not seem to be working correctly

I changed the code from:

response = requests.post("cancel_order/", data=data) return self._expect_true(response)

to:

return self._post("cancel_order/", data=data).json()

To make it look like the code in the other methods and that seemed to have fixed it.

SmileyChris commented 10 years ago

Go on -- submit a pull request, it's good practice :)

Github makes it easy:

  1. commit your change to your local repo
  2. fork on github
  3. add your new fork as a remote to your local repo
  4. push to your fork (preferably to a specific branch, but whatever)
  5. come to github and click the magic "make pull request" button
kmadac commented 10 years ago

Thanks for creating issue. As Chris wrote. Pull request is great feature of GitHub. You can find more about PR here: https://help.github.com/articles/using-pull-requests#fork--pull

kmadac commented 10 years ago

Pull request was merged, so I'm closing the issue.