search

kmadac / bitstamp-python-client

Python package to communicate with bitstamp.net
MIT License
143 stars 70 forks source link

Added support for implementing v2 API calls #19

Closed bartbroere closed 8 years ago

bartbroere commented 8 years ago

Added support for v2 API calls The commit is backwards compatible New API methods now raise the same type of error

kmadac commented 8 years ago

Hi @bartbroere, it's great that you are working on API v2 update. I will try to check commits you made constantly, but please let me know here once your work will be done and I will try PR as soon as possible. Of course we need to have unit tests made for all new functions.

bartbroere commented 8 years ago

Hi. No problem, I'm happy you're considering merging it. I have added placeholder unit tests, and I am testing updated methods with my own API key to make sure it all works as expected. If there's time I will make the unit tests tomorrow.

There is of course new functionality to the API client, so a new version number might be necessary when you merge the pull request. I will let you know when I'm done.

bartbroere commented 8 years ago

The new API methods did not raise errors in the same way as the old one. This now has been fixed. @kmadac I think the pull request is ready to be merged.