kmadac / bitstamp-python-client

Python package to communicate with bitstamp.net
MIT License
143 stars 70 forks source link

Can we do a stop order or stop trail order? #28

Closed TheLegendAli closed 5 years ago

TheLegendAli commented 6 years ago

I couldnt find it in documention. If so please guide

kmadac commented 6 years ago

Bitstamp API have exposed Buy/Sell limit order and Buy/Sell Market order and these are implemented already. You can find it in source code here: https://github.com/kmadac/bitstamp-python-client/blob/582a9ae5c3810987a45db0f3dbdf7a9b6d203591/bitstamp/client.py#L305

Is this what you are looking for?

TheLegendAli commented 6 years ago

Nope.

On bitstamp you can make market, limit and stop orders. https://www.bitstamp.net/market/order/stop/

I want a way to make stop orders through the api

kmadac commented 6 years ago

As this project is only wrapper of Bitstamp REST API and the API doesn't expose such functionality, we cannot add it. Once Bitstamp will add it I can add it as well in matter of hours.

TheLegendAli commented 6 years ago

Thats what I thought.

Anyway thanks for your efforts

On 1 Jan 2018 23:01, "Kamil Madac" notifications@github.com wrote:

As this project is only wrapper of Bitstamp REST API and the API doesn't expose such functionality, we cannot add it. Once Bitstamp will add it I can add it as well in matter of hours.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kmadac/bitstamp-python-client/issues/28#issuecomment-354680369, or mute the thread https://github.com/notifications/unsubscribe-auth/ABq4NV5a9WOzDtSDN8U4-XmdtCYjcS2Lks5tGVXFgaJpZM4RPvwO .

TheLegendAli commented 6 years ago

Actually one follow-up question:

is there a way that we can include the limit_price in the limit order?

Bitstamp APi allows for the price amount and limit_price amount for the limit order. I'm not sure how we can include that in the python wrapper.

https://www.bitstamp.net/api/

Deelight-fr commented 6 years ago

limit_price argument wad added thorugh merge https://github.com/kmadac/bitstamp-python-client/pull/30