Closed steelbrain closed 6 years ago
I very much want to see this included in a release soon! We rely on babel-watch in our docker dev pipeline, and see this https://github.com/kmagiera/babel-watch/issues/47 error a few times a day. Please merge this and release it @kmagiera ! Thanks
Is this PR going to be merged soon?
Would love to see this PR merged too :)
Fixes https://github.com/kmagiera/babel-watch/issues/47
Post mortem of issue
The issue
childApp.kill()
and instantly null pipeFdkill
is an asynchronous operation, between us calling it and it happening, the app sends a request that hits this line https://github.com/kmagiera/babel-watch/blob/0bb38ce492b32ae196574a8b36daa79c5a7f61e5/babel-watch.js#L291The solution
childApp.kill()
and only null-out once the process actually exitsWorst case scenario with this fix: