search

kmaragon / Konscious.Security.Cryptography

MIT License
202 stars 20 forks source link

NuGet package is wrong #16

Closed meh-uk closed 6 years ago

meh-uk commented 7 years ago

Hey

Your Nuget package is missing dependencies on:

kmaragon commented 7 years ago

Could you elaborate a bit?

The package doesn't use any of these. It uses System.Runtime.InteropServices but that one isn't listed here. What made you think that these need to be dependencies?

meh-uk commented 7 years ago

I think the Vector.IsHardwareAccelerated isn't included in .NET 4.5.2. Perhaps it all works fine with .NET 4.6 which unfortunately we aren't using :(.

kmaragon commented 7 years ago

It's not. But in theory, the nuget package should support 4.5.2:

https://www.nuget.org/packages/System.Numerics.Vectors

This is referenced as 4.* in the nuget package. So it should get the latest System.Numerics.Vectors package which should support >= .NET 4.5

It will not, however, support anything older

kmaragon commented 7 years ago

Maybe 4.* is resolving the preview release? 4.4.x? Which is >= 4.6

kmaragon commented 6 years ago

I'll close this as I'm guessing it was probably a nuget config that is explicitly using experimental packages. With that said, I'll change the version tag to 4.3.* on the next publish, knowing that newer versions of the .NET libraries are going to break compatibility with 4.5.2 when they're released as stable.