search

kmaragon / Konscious.Security.Cryptography

MIT License
202 stars 20 forks source link

MemorySize is measured in KiB, not KB as per README #31

Closed danrs closed 4 years ago

danrs commented 4 years ago

The Konscious.Security.Cryptography README claims that argon2 MemorySize is measured in kilobytes. This should say kibibytes instead.

The reference implementation says it uses kibibytes, as do other implementations such as argon2-cffi.

When comparing output from argon2-cffi and Konscious argon2, the same hash is only produced if both memory size parameters are the same. Using 8192 for Konscious and 8000 (8192KB in KiB) for argon2-cffi does not produce the same hash.

kmaragon commented 4 years ago

Glad to have an issue that doesn't take a time commitment that I can't currently make. But I do have 5 min in the morning before work to update a word in the README. Updated. Thanks.