kmaragon / Konscious.Security.Cryptography

MIT License
202 stars 20 forks source link

HMACBlake2B: Given implementation is not tested (but default behavior) #42

Closed HugoRoss closed 2 years ago

HugoRoss commented 3 years ago

In class HMACBlake2B, there is a constructor overload that accepts the desired implementation which is then assigned to an instance field "_createImpl", but the provided function is never invoked, always "CreateImplementation" is used to initialize the implementation. As a consequence, the tests are not testing both implementations but the same implementation twice.