search

kmaragon / Konscious.Security.Cryptography

MIT License
201 stars 20 forks source link

Official Release offers Argon2d, Argon2i, and new hybrid "id" #7

Closed SparkDustJoe closed 5 years ago

SparkDustJoe commented 7 years ago

Will that hybrid be supported in this codebase?

https://github.com/P-H-C/phc-winner-argon2/commit/a664086ca95ea5d9168a60baa5da3a5f4ac34801 https://github.com/P-H-C/phc-winner-argon2/releases/tag/20161029

Thanks

kmaragon commented 7 years ago

The answer is yes... but when is a major question. Aside from my time constraints, I need to go reread the doc to see what the updates are. I expect to start soon but I don't know when it will be done. My higher priority is to do some optimization work. But I am kind of waiting for:

https://github.com/dotnet/coreclr/issues/445

So I can get a reliable profiler up on Linux to do the optimization. The main reason that I am prioritizing that is so that I don't have more code that needs rework / optimization once I have an idea of where I can optimize. I did some crappy SIMD optimization already but I don't actually even know if that's better than the un-vectorized version, since there's some overhead to arranging the data in memory to be vectorizable. A profiler would help me figure that out.

SparkDustJoe commented 7 years ago

That post has had a lot of comments and new issues spawn from it, so they are definitely working on it, but it looks like Fall of this year will be the target release for *nix.

kmaragon commented 6 years ago

This is really old. But I wanted to add a comment that I have a local branch with this implemented. But I have the overhead to start generating test cases with the reference implementation and write the tests to verify what I have. But if I manage a couple of days off of work, I think I'll have this soon... assuming it ends up being as trivial as it turns out to have seemed.

ffMathy commented 5 years ago

Please keep us updated!

flacidsnake commented 5 years ago

Any news regarding this?

Thank you

johnnyRose commented 5 years ago

+1, would love to see this when you have a chance.

kmaragon commented 5 years ago

Sorry for the delay on this - I just opened the PR with Argon2id support for myself to review :stuck_out_tongue:

But really it's to just run it through CI. I'll publish the package tomorrow (1/4/2019) assuming all goes well there.

It'll be version 1.2.0 when it's up

kmaragon commented 5 years ago

15 minutes later - it's uploaded. I forgot how much faster C# packages are than C++ packages.

johnnyRose commented 5 years ago

Thanks a lot, @kmaragon!