search

kmarius / jsregexp

JavaScript regular expressions for Lua
MIT License
28 stars 4 forks source link

Stop hardcodiing CC=gcc #24

Closed Natthias closed 2 weeks ago

Natthias commented 2 weeks ago

Currently, the makefile hardcodes CC=gcc, which forces user to invoke make cc=<c compiler> to compile the software.

It would make more sense to just remove the CC=gcc and have the Make handle this. For GNU Make, this would just default to cc as the c compiler (cc is usually symlinked to gcc), unless CC is set in the environment.

It would also help distributions such as Chimera Linux, which use llvm/clang for the system toolchain.

kmarius commented 2 weeks ago

I have no objection to removing that option, however I very much don't want try and to make the Makefile work on every environment. Luarocks does a much better job at that.

Natthias commented 2 weeks ago

Distros using llvm/clang as the toolchain can't really use luarocks without compiling from source, as they are missing libgcc, but that is more of a luarocks issue than anything else. Closing as the issue has been addressed, thank you.