search

kmaterna / Strain_2D

Strain rate modeling from GNSS velocity fields
MIT License
44 stars 19 forks source link

Geostats strain values with possible units problem #15

Closed kmaterna closed 3 years ago

kmaterna commented 3 years ago

@jlmaurer I got geostats working! But even with several sets of parameter choices, I suspect a units problem (off by 1000) in the strain or velocity output grids. Top: comparative max_shear, regular for the first 4, but I multiply geostats' max_shear by 1000. Bottom: standard Strain_2D plots of dilatation and 2nd invariant from my geostats run. The 2nd invariant plot is clearer about the 1000x thing.

Screen Shot 2021-09-29 at 6 36 51 PM

By the way, I couldn't help myself and made a few cosmetic changes (no change in function) to the geostats file, based on IDE stuff. I hopefully didn't do anything too overbearing or controversial; it helps me see any real problems through a pared-down set of IDE warnings.

jlmaurer commented 3 years ago

Not a problem!

Interesting, but I think if I remember correctly there was an off-by-1000 issue elsewhere we fixed a while back. Probably I had written geostats to be consistent with he older version, and now it's different. That's what I would guess, can check into it or you can as well!

Jeremy

On Wed, Sep 29, 2021, 8:43 PM kmaterna @.***> wrote:

@jlmaurer https://github.com/jlmaurer I got geostats working! But even with several sets of parameter choices, I suspect a units problem (off by 1000) in the strain or velocity output grids. Top: comparative max_shear, regular for the first 4, but I multiply geostats' max_shear by 1000. Bottom: standard Strain_2D plots of dilatation and 2nd invariant from my geostats run. The 2nd invariant plot is clearer about the 1000x thing. [image: Screen Shot 2021-09-29 at 6 36 51 PM] https://user-images.githubusercontent.com/12519252/135371477-fcdd59ff-34bd-46ba-a802-0c6f13685869.png

By the way, I couldn't help myself and made a few cosmetic changes (no change in function) to the geostats file, based on IDE stuff. I hopefully didn't do anything too overbearing or controversial; it helps me see any real problems through a pared-down set of IDE warnings.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kmaterna/Strain_2D/issues/15, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFJM4TKT2ZGZUT6BEKNF3DDUEO6FBANCNFSM5FBFVKVA .

kmaterna commented 3 years ago

@jlmaurer I put in a fix to do 1000x. Seems to be working so far. We will talk results next time.

I also built this .md when I didn't feel like doing other things: https://github.com/kmaterna/Strain_2D/blob/master/param_definitions.md