Fix some bugs in geostats, update some text and imports

kmaterna / Strain_2D

Strain rate modeling from GNSS velocity fields

MIT License

44 stars 19 forks source link

Fix some bugs in geostats, update some text and imports #6

Closed jlmaurer closed 3 years ago

jlmaurer commented 3 years ago

Changed imports for clarity and because the old version wasn't working, @kmaterna you had better check that these don't break on your end
Updated the help message with new program names
Fixed bugs in strain_geostats
Moved some helper functions to utilities in case useful for other methods
Added a temporary fix converting degrees to km in strain rate calc

jlmaurer commented 3 years ago

@kmaterna it's working!!! I was able to run several models including geostats and compare them. My next step is to determine better covariance parameters for northern California. :)

jlmaurer commented 3 years ago

@kmaterna I put back the local import statements, except for in the models. Here I'm importing a specific function (strain_2d), and wasn't sure which is cleaner.

from strain.models.strain_2d import Strain_2d
model = Strain_2d()

versus

from . import strain_2d
model = strain_2d.Strain_2d() # etc.

I typically like the former because it explicitly imports functions so that calling the is cleaner, but could go either way here.

kmaterna commented 3 years ago

Your branch works on my computer too! new conda env from the yml and everything. It was easy to do.

I'm happy to use the strain.models.strain_2d import structure for the classes; I'll merge and then inspect the other import statements.