finalizing remote-ctrl and hook-script patchset

[x42]

Hi kjetil,

As discussed previously, here's the wrap completing the patchset.

for the README changelog:

• allow to remote-control jack-capture via OSC:
• added exec-hooks: jack_capture can launch an external app in fire&forget mode (from the disk-thread).
  • when it opens a new file for writing
  • when it closes a file, recording finished
  • on file-name-rotation
  • when first audio frame is received.
• write a timestamp file with sample-accurate system time of the start of recording.
• forced file-name rotatation every N audio-frames.

[kmatheussen]

Looks good.

When using the -Rf option, the program sometimes segfaults, and it almost always says "Internal error : SF_INFO struct incomplete.". It not unlikely to be caused by my code though, so I'll look into it.

Minor: A simpler way to write "(int64_t) atol(OPTARG_GETSTRING());" is "OPTARG_GETINT();"

Also, it seems like I overlooked the command line arguments in your last patch set. It would be nice if all the options had an identifier character to indicate if the option requires an argument: [--rotatefile N] or [-Rf N] -> force rotate files every N audio-frames.

[kmatheussen]

Fixed the segfault. jack_samplerate() was called after jack client was closed.

[kmatheussen]

Also updated the command option documentation, and updated the README file.

[kmatheussen]

Seems like the jack client has been closed too early. Should make a new release because of that. Does the changelog in README look okay?

[x42]

wow you're quick!

Yes, README looks good. and thanks for updating the option documentation.

I have not experience the segfault (maybe jack1/jack2 thingy? I runs jack1.9.9).

One thing I was not sure of: code-indenting, tabstops. -- my tabs default to shift-width (both 2 spc), you mostly use 8space tabs; I've adjusted most of my patch to that but some mistakes slipped through -- but the code-base was inconsistent before.

Last but not least: what's your take on all those #ifdefs - should they remain?

[kmatheussen]

I run jack 1.9.7. Guess that could explain it.

I'm using 2 spc indentation. Could be 8space tabs somewhere in the code, but that's not what I use.

I don't like the #ifdefs that much. I wouldn't mind if you removed EXEC_HOOKS, STORE_SYNC and AUTOROTATE.

[x42]

ack. I'll remove those and move all the additional #includes to the top. ETA: late afternoon or early evening today.. gotta run into a few meetings now.

HAVE_LIBLO could actually go, too. liblo is available on pretty much any platform these days.