Closed Claudenw closed 3 years ago
Yes, something is wrong there. I don't quite understand why these variables should be cleared either. @x42 I think you wrote this code, do you remember why these variables are cleared? It seems related to OSC: https://github.com/kmatheussen/jack_capture/blob/bd713b3b5f54ae0d653dd19f0901e67f55aac209/jack_capture.c#L1356
Yeah looks like a SNAFU.
The code should be changed to print first, then reset the per-file counters.
The total_*
variable should probably never be reset, except there's currently no xruns
vs. total_xruns
distinction.
x-runs are relevant per file, not per recording session.
Fixed in d2cb18
https://github.com/kmatheussen/jack_capture/blob/bd713b3b5f54ae0d653dd19f0901e67f55aac209/jack_capture.c#L1326
I see that jack_capture.c lines 1326 - 1338 sets the disk_erorr, total_overruns and total_xruns to zero and then checks if they are greater than zero to print warning messages.