search

kmatheussen / jack_capture

A program for recording soundfiles with jack
http://www.notam02.no/arkiv/src/
Other
75 stars 28 forks source link

Support opus output format #42

Closed orivej closed 3 years ago

orivej commented 3 years ago

opus output requires libsndfile built with libopus. If libsndfile was built without it, jack_capture will report that libsndfile does not support the requested format and exit.

If someone later wants to add configurable compression level, it is controlled by a double SFC_SET_COMPRESSION_LEVEL in range between 0.0 (meaning 256 kbps per channel) and 1.0 (meaning 6 kbps per channel).

Fixes #22

kmatheussen commented 3 years ago

Thanks! I don't have libsndfile with opus. Have you tested it and it works fine?

kmatheussen commented 3 years ago

It doesn't just create an ogg file with .opus suffix?

kmatheussen commented 3 years ago

Thank you. No worries, I believe you. Just want to make sure you have actually tested it. :-)

Another thin, I see now that you've also removed the test if libsndfile is compiled with OGG. Why did you do that?

kmatheussen commented 3 years ago

Is the test moved to gen_setformat_c.sh? Sorry, it's been so long since I've looked at the code.

orivej commented 3 years ago

Sorry, there were some WIP pushes. Now it looks good, and I've checked that -f wav, ogg and flac work as before, while -f opus writes ogg/opus. EDIT: --ogg-quality (without -f) also works as before.

kmatheussen commented 3 years ago

Sorry, forgot about this one.

kmatheussen commented 3 years ago

Thank you.