search

kmatheussen / jack_capture

A program for recording soundfiles with jack
http://www.notam02.no/arkiv/src/
Other
75 stars 28 forks source link

An improper locking bug(e.g., deadlock) on the lock vrb->increase_lock #47

Closed ycaibb closed 3 years ago

ycaibb commented 3 years ago

Hi, developers, thank you for your checking. It seems the lock vrb->increase_lock is not released correctly when das_buffer==NULL in the function vringbuffer_increase_writer1?

https://github.com/kmatheussen/jack_capture/blob/e2c0c3d25fce0a13f3f18c622079cd29178af7f8/vringbuffer.c#L129-L139

kmatheussen commented 3 years ago

Thanks. Fixed. It was in practice a no-op though, and could never have causes any real problems as far as I could see. The only problem in the code was that out of memory during program startup was not properly handled.

ycaibb commented 3 years ago

OK，thank you for your explanation！