search

kmatheussen / radium

A graphical music editor. A next generation tracker.
http://users.notam02.no/~kjetism/radium/
GNU General Public License v2.0
852 stars 37 forks source link

sequencer bar grid lines don't line up musically. #1205

Open Lykdraft opened 5 years ago

Lykdraft commented 5 years ago

I noticed a very odd design choice.

The background grid in the sequencer looks very weird when zoomed out a bit. I see strong lines at the beginning of bar 4,7,10,13,16 and so on.

Usually in every DAW I know you have those lines at 5,9,13,17 and so on. (Oddly enough, the 13 is correct. So I am not sure why that is... More examples: The 25 is correct as well, the 34 is off, should be 33.)

This is weird, because you usually need to see when a new musical measure starts, (i.e.: in 4/4 this is after 4 bars have played, thus on 5 you have a visual aid, not on 4, which actually means that a visual aid is at an odd position since only 3 bars have played at that point in time...)

Simple example: When we have 2 blocks with a 32 line lenght in the sequencer, a big gridline cuts through the middle of the second block (at position 4) which doesn't make sense. It gives an odd impression. The Gridline should be on 5, which indicates that at that point 4 bars have played.

I hope this makes sense.

Best, tL.

(Obviously you could expand on that and let the background grid adapt to the time signature for easier visual guide/alignment for other timesignatures than 4/4)

Lykdraft commented 5 years ago

Ah, I see. This behavior is zoom dependent. Looks like this is only happening at an "inbetween" zoom setting. I can see the lines snap out of place when zooming out and when zooming out even more, they snap back in place. Weird.

(EDIT: And then snap out of place again when zooming out even more and back in place once again and so on and so forth.)

Lykdraft commented 5 years ago

That said, maybe recallable zoomsettings might be a good addition as well.

kmatheussen commented 5 years ago

Yeah, it sounds less confusing if the background grid was always placed at the same bar numbers. For instance, either

Currently the program tries to spread the number of grid lines approximately so that not too many or too few lines are shown. Also, it shouldn't make a difference whether signature is 3/4,4/4,3/8,5/4, etc.

On Wed, May 8, 2019 at 4:07 AM Lykdraft notifications@github.com wrote:

That said, maybe recallable zoomsettings might be a good addition as well.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kmatheussen/radium/issues/1205#issuecomment-490319291, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIX3J4EA7JZ7OOVY63IHX3PUIYVJANCNFSM4HLNXPJQ .

Lykdraft commented 5 years ago

Also, it shouldn't make a difference whether signature is 3/4,4/4,3/8,5/4,

True. Of course it shouldn't. Was late yesterday.