kmatheussen / radium

A graphical music editor. A next generation tracker.
http://users.notam02.no/~kjetism/radium/
GNU General Public License v2.0
843 stars 36 forks source link

Add the ability to use the alt key as a horizontal scroll modifier #1420

Closed akimaze closed 9 months ago

akimaze commented 9 months ago

Hi, This PR partially fixes https://github.com/kmatheussen/radium/issues/1393. I added an option in preferences to change horizontal scroll modifier from Windows/Meta/Super key to Alt. This fixes the biggest problem on some desktops like Cinnamon that always uses that key to show main menu and makes it unusable.

I added option to GUI tab currently because that's only one checkbox:

image

I didn't find any conflict with current keybindings when alt is used as horizontal scroll modifier. Windows/Meta key is still the default modifier.

kmatheussen commented 9 months ago

Looks good. Thanks!

kmatheussen commented 9 months ago

All modifier keys should probably be configurable, but that's another task.

kmatheussen commented 7 months ago

I've pushed a commit that adds caching for SETTINGS_read_bool/SETTINGS_writebool. It's using a general template class which is easy to use if you need cached behavior for other SETTINGS*-functions later.