kmatheussen / radium

A graphical music editor. A next generation tracker.
http://users.notam02.no/~kjetism/radium/
GNU General Public License v2.0
854 stars 37 forks source link

update faust #1423

Closed ghost closed 10 months ago

ghost commented 10 months ago

it's about time for radium's faust to be updated again i think

particularly i'm working on a synth and i noticed that it seems to compile faster on the newer version of faust in their web ide and i'm wondering whether updating it will help its compilation in radium

ghost commented 10 months ago

bump

kmatheussen commented 10 months ago

I'll prioritize it.

yust1n commented 10 months ago

Updated. When compiling on Arch there needs to be one more patch uncommented in bin/packages/build.sh.

ghost commented 10 months ago

alright, i compiled the latest version with the updated faust

now any .dsp loaded into the faust dev gives the error "basics.lib:1565:syntax error"

ghost commented 10 months ago

i think i found the problem

line 1565 contains a definition for a function called "round"; an actual round primitive was recently added per https://github.com/grame-cncm/faust/issues/950

i'll test removing it and seeing what happens. this may require a bug report at the faust repo

ghost commented 10 months ago

yay! my patches work again

yust1n commented 10 months ago

I don't get any error with the dsp you mentioned in your link https://faustcloud.grame.fr/doc/examples/index.html#foursourcestoocto but I am curious on your patches now :D K. Gotcha @autumncheney I updated the faustlibraries and got the same error today.

yust1n commented 10 months ago

@autumncheney Finally managed to update and test the latest faustlibraries successfully with the foursourcetoocto.dsp. Thanks for pointing out the error.

ghost commented 10 months ago

yes, i built this commit with the updated libraries and everything works now

thank you so much by the way for the commits @yust1n

kmatheussen commented 10 months ago

Than you @yust1n

yust1n commented 10 months ago

Do you mind if I slim down the faustlibraries @kmatheussen ? the .git-dir in the tarfile is really big and not needed at all.

kmatheussen commented 10 months ago

Sure, can't see what we need the .git-dir for. :-)

On Sun, Jan 14, 2024 at 12:40 PM yust1n @.***> wrote:

Do you mind if I slim down the faustlibraries @kmatheussen https://github.com/kmatheussen ? the .git-dir in the tarfile is really big and not needed at all.

— Reply to this email directly, view it on GitHub https://github.com/kmatheussen/radium/issues/1423#issuecomment-1890927219, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIX3J22XMCLHTBYLFW5HUDYOO73LAVCNFSM6AAAAABBPTQK6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJQHEZDOMRRHE . You are receiving this because you were mentioned.Message ID: @.***>

yust1n commented 10 months ago

It was part of the tarfile and an easy way to check if you did any moddings like in libpd. Btw. where can I talk to you about updating libpd ? Been digging in this and found lots of culprits since pure-data-extended got discontinued a long time ago. The forum is still down :(