kmatheussen / radium

A graphical music editor. A next generation tracker.
http://users.notam02.no/~kjetism/radium/
GNU General Public License v2.0
835 stars 36 forks source link

Moving on from using qt5webkit? #1425

Closed mxmilkiib closed 5 months ago

mxmilkiib commented 5 months ago

There is no longer a binary qt5webkit package for Arch, and there hasn't been for a while now, and it takes an incredibly long time to compile.

Will moving on from using it be in the future of Radium?

kmatheussen commented 5 months ago

No, the alternative qt replaced it with isn't good enough. It's missing some important features, don't remember exactly what it was right now. And I don't think the alternative compiles under mingw. Also, qt5webkit is still being developed, although not muchm but there's even a branch for qt6 at least.

kmatheussen commented 5 months ago

You can try changing the USE_QWEBENGINE macro in the code though. It might still work using the other one.

kmatheussen commented 5 months ago

(I'll see if I can make it compile again, but I won't enable it by default)

kmatheussen commented 5 months ago

It still compiles without any changes. :-) Just Change USE_QWEBENGINE to 1, add Qt5WebEngine, Qt5WebEngineCore, Qt5WebEngineWidgets to Makefile.Qt, etc. You can't zoom in on the faust graph in the FaustDev instrument though, I think that's the only reason for not using it. I'll see if I can make it so that you only can set an environment variable if you want to use qwebengine instead of qtwebkit.

mxmilkiib commented 5 months ago

That would be marvelous, thank you! Might upstream have an opinion on reimplementing that lacking feature? Cheers again.

kmatheussen commented 5 months ago

I've added option to set the environment variable USE_QWEBENGINE to 1 to use qwebengine instead of qtwebkit, but the dsp graph in the faust instrument is quite useless when you do that.

kmatheussen commented 5 months ago

I'm not sure, but I don't think Qt switched to qwebengine because it's better or newer.

kmatheussen commented 5 months ago

Seems like I forgot to comment on this. But it should be fixed now.