kmatheussen / radium

A graphical music editor. A next generation tracker.
http://users.notam02.no/~kjetism/radium/
GNU General Public License v2.0
843 stars 36 forks source link

Fabla LV2 Plugin can't create new presets in Radium #1429

Closed yust1n closed 8 months ago

yust1n commented 8 months ago

1. Steps to reproduce the problem.

The bug does not seem to happen when used in Ardour8.

yust1n commented 8 months ago

Solved by switching to LSP-Multi-Sampler since presets also don't get selected correctly when reloading the song.

yust1n commented 8 months ago

I finally realized that playing with samplerplugins in radium is one of the most stupid ideas I ever had. Please forgive me Kjetil ;D

kmatheussen commented 8 months ago

I think there is a misunderstanding about what the preset list is. That list communicates directly with the plugin, through juce by calling juce::AudioPluginInstance::changeProgramName. It might be that this functionality doesn't work at all for LV2 plugins, nothing happened when I tried it at least. To create presets in Radium, you need to use the "Load" and "Save" buttons to left of these buttons.

kmatheussen commented 8 months ago

Also, the plugin itself must probably support changing the name of presets. I guess it's confusing to have this functionality which sometimes, maybe most of the time, doesn't do anything. I'll add some info to the requester to avoid this misunderstanding.

yust1n commented 8 months ago

I was expecting this to work like in Ardour where a new preset gets created in ~/.lv2 or when you run a plugin in jalv which also does it this way. My bad :/. Thanks for explaning :) https://github.com/drobilla/jalv/blob/ce4a6f7ec4dc9191bcb7a0efe91770a53500b5bf/src/state.c#L202