Remember main window position size/state opened windows (sequencer, mixer) and edit/instrument gui visibilty - Githubissues

kmatheussen / radium

A graphical music editor. A next generation tracker.

http://users.notam02.no/~kjetism/radium/

GNU General Public License v2.0

835 stars 36 forks source link

Remember main window position size/state opened windows (sequencer, mixer) and edit/instrument gui visibilty #1433

Closed akimaze closed 5 months ago

akimaze commented 5 months ago

This PR fixes https://github.com/kmatheussen/radium/issues/1378 for me.

I use Radium on three monitor setup currently every time I start Radium I have to:

open sequencer in own window
move it to another monitor
maxmize seq window
open mixer
click W to open it in its own window
move mixer window to another monitor
show instrument gui
hide edit gui
maximize main window

That PR saves me a lot of work ;) by saving/restoring windows state. With this changes I simply start Radium and everything is prepared properly. Tested on three monitor setup only on linux.

kmatheussen commented 5 months ago

Great work, nothing wrong with the code as far as I can see. Going to test it soon.

kmatheussen commented 5 months ago

I'm not sure if I'm going to test it today. If you feel confident that you won't change very much, feel free to pull it into the main repo yourself. I'm going to do that before testing anyway.

akimaze commented 5 months ago

I'm not sure if I'm going to test it today. If you feel confident that you won't change very much, feel free to pull it into the main repo yourself. I'm going to do that before testing anyway.

I have my own build with these changes, so there is no hurry :) Currently, I haven't found any problem, so I don't plan to change anything.

kmatheussen commented 5 months ago

I notice that the sequencer widget and the instrument widget are now placed in the mixer, by default. Is it a bug or is there a reason for doing that?

kmatheussen commented 5 months ago

Small bug: The "W" checkbox in the mixer is not checked after startup when it's in it's own window. You have to press it twice to put it back into the main window. I can probably fix it if you want.

kmatheussen commented 5 months ago

I notice that the sequencer widget and the instrument widget are now placed in the mixer, by default. Is it a bug or is there a reason for doing that?

Sorry, I guess that was just my old settings.

akimaze commented 4 months ago

Small bug: The "W" checkbox in the mixer is not checked after startup when it's in it's own window. You have to press it twice to put it back into the main window. I can probably fix it if you want.

I am currently finishing my next song (of course in Radium), so it would be great if you could fix that issue.