search

kmayerb / tcrdist3

flexible CDR based distance metrics
MIT License
53 stars 17 forks source link

Added a missing argument when calling _synthesize_vj_matched_background #58

Closed zozo123 closed 2 years ago

zozo123 commented 2 years ago

In the current code base only in the case of chain="beta" the n argument was properly propogated. This commit fixed this by passing the argument to the underline function _synthesize_vj_matched_background. Similar to what was done for the case of beta chain.

Signed-off-by: Yossi Eliaz eliaz123@gmail.com

zozo123 commented 2 years ago

@kmayerb, any ideas why we see this error:

Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.8.11/x64/lib/python3.8/site-packages/coveralls/cli.py", line 93, in main
    result = coverallz.wear()
  File "/opt/hostedtoolcache/Python/3.8.11/x64/lib/python3.8/site-packages/coveralls/api.py", line 257, in wear
    return self.submit_report(json_string)
  File "/opt/hostedtoolcache/Python/3.8.11/x64/lib/python3.8/site-packages/coveralls/api.py", line 293, in submit_report
    raise CoverallsException(
coveralls.exception.CoverallsException: Could not submit coverage: 422 Client Error: Unprocessable Entity for url: https://coveralls.io/api/v1/jobs
Error: Process completed with exit code 1.
kmayerb commented 2 years ago

It appears to be an error specific to coverall, as all unit and integration tests are passing.

zozo123 commented 2 years ago

@kmayerb, great! Would you like merge it?

kmayerb commented 2 years ago

I am trying test with: 

run: coveralls --service=github

to see if that solve the issue of Coveralls fails to upload with HTTP 422 "Unprocessable Entity"

Alternatively, if it has to do with the pull request, i can commit and merge your changes.