kmayerb / tcrdist3

flexible CDR based distance metrics
MIT License
53 stars 17 forks source link

Convention N/C terminal #87

Open lisadratva opened 1 year ago

lisadratva commented 1 year ago

Hi kmayerb,

Thanks for the nice tool! I've been tuning the ntrim/ctrim parameters and wanted to flag an error - usually, the convention on writing CDR3s should be from N-terminal (starting with the IMGT position 105, after the 2nd conserved cysteine) to C-terminal (ending with IMGT position 117). This seems to be explained the wrong way around in your documentation. Could you please check whether this is implemented correctly in the code, e.g. considering trimmed sequences as [n_trim : -c_trim] ?

Thank you!