search

kmayerb / tcrdist3

flexible CDR based distance metrics
MIT License
53 stars 17 forks source link

Added support on pandas version 1.5.0+ due to the issue caused by **pandas.DataFrame.iteritems**. #96

Open OumaeKaede opened 6 months ago

OumaeKaede commented 6 months ago

Dear @kmayerb Since Pandas version 1.5.0, pandas announced to romove the function pandas.DataFrame.iteritems in the future version of pandas, especially pandas v2.2.1 in 2024.

See https://pandas.pydata.org/pandas-docs/version/1.5/reference/api/pandas.DataFrame.iteritems.html

I've discovered the issue caused by function pandas.DataFrame.iteritems in tcrdist v0.2.2 in gene_pairing_plot.py/rep_diff.py/summarize.py when installing Pandas version later than 1.5.0. However, the automatic installing of tcrdist3 in pip will install the lastest version of pandas and some of the fresh pythoners will not discover the problem caused by pandas.

Thus makes the change. (I've tested that all changes can work correctly.) Best wishes Oumae Kaede in KI

kmayerb commented 6 months ago

Thanks for taking the time to make a pull request. Looks like we need to find all instances of .iteritems() !

pavlovicmilena commented 2 months ago

Hi @kmayerb, will this change soon be available on the master branch and PyPI? Thank you!

kmayerb commented 1 week ago

This change should now be updated in PiPY version

pip install tcrdist3==0.3