search

kmcgill88 / McPicker-iOS

McPicker is a customizable, closure driven UIPickerView drop-in solution with animations that is rotation ready.
MIT License
213 stars 43 forks source link

Added SPM support #71

Closed lukemmtt closed 1 year ago

lukemmtt commented 2 years ago

Did not do any tests to see if this breaks the CocoaPods install.

kmcgill88 commented 2 years ago

Hi @lukemmtt I haven't been actively developing this anymore but i'm happy to add you as a maintainer if you like?

lukemmtt commented 2 years ago

That would be great, thanks Kevin! I still use this module to this day in my app TimeFinder, so I'll be glad to help maintain it so long as it remains a part of the project. https://apps.apple.com/us/app/schedule-planner-time-finder/id1347447233

kmcgill88 commented 2 years ago

Hi @lukemmtt I haven't been actively developing this anymore but i'm happy to add you as a maintainer if you like?

Got you added @lukemmtt !

warpling commented 1 year ago

@lukemmtt would love to see this merged if it still works :)

lukemmtt commented 1 year ago

@warpling I don't seem to have permission to do that, unfortunately!

@kmcgill88, can you help?

kmcgill88 commented 1 year ago

@lukemmtt your previous invite to join as a collaborator expired. I just fired off a new invite. Accept that and I think you'll have all the power!

lukemmtt commented 1 year ago

Thanks @kmcgill88 ! 🙏🏻

@warpling All taken care of 🚀 Although until we make a new "release", you'd need to ensure to use the master branch rather than the latest official release.

warpling commented 1 year ago

Nice work! Maybe worth quickly updating the README and cutting a new tag for anyone else coming along that doesn't see this PR? :)

lukemmtt commented 1 year ago

@warpling I'd prefer if you or someone else could attest that this PR hasn't broken anything in the cocoapods version (see my original comment), then I'd be glad to make a new release