kmcgill88 / admob_flutter

Admob Flutter plugin that shows banner ads using native platform views.
https://pub.dartlang.org/packages/admob_flutter
ISC License
435 stars 151 forks source link

GMA SDK 7.64.0 #272

Open MrVipinVijayan opened 3 years ago

MrVipinVijayan commented 3 years ago

Hi,

Could you please update the SDK with GMA SDK 7.64.0. Admob consoles are showing warnings because of this and it may affect revenue.

Thanks Vipin

efraespada commented 3 years ago

There is a problem when compiling this plugin with the latest versions of Firebase Analytics.

[!] CocoaPods could not find compatible versions for pod "GoogleAppMeasurement":
      In Podfile:
        admob_flutter (from `.symlinks/plugins/admob_flutter/ios`) was resolved to 1.0.0, which depends on
          Google-Mobile-Ads-SDK (~> 7.64) was resolved to 7.67.0, which depends on
            GoogleAppMeasurement (~> 6.0)

        firebase_analytics (from `.symlinks/plugins/firebase_analytics/ios`) was resolved to 8.1.0, which depends on
          Firebase/Analytics (= 8.0.0) was resolved to 8.0.0, which depends on
            Firebase/Core (= 8.0.0) was resolved to 8.0.0, which depends on
              FirebaseAnalytics (~> 8.0.0) was resolved to 8.0.0, which depends on
                FirebaseAnalytics/AdIdSupport (= 8.0.0) was resolved to 8.0.0, which depends on
                  GoogleAppMeasurement (= 8.0.0)
loicgeek commented 3 years ago

@efraespada did you solve this ?

FernandoUFS commented 3 years ago

I am unable to submit a new version to AppStore due this error. I have exactly the same error here after upgrade firebase dependencies.

armandojimenez commented 3 years ago

How do I fix this? my project does not even compiles anymore, needs sdk 8.0

xiprox commented 3 years ago

EDIT: Never mind. The actual plugin code doesn't seem to be compatible with the newer version.

Didn't actually test and I don't know what it could break (close to zero iOS knowledge), but bumping the version in podspec in my fork fixed pod install for me.

If you'd like to give it a go, in your pubspec:

admob_flutter:
  git:
    url: https://github.com/xiprox/admob_flutter
    ref: ca12b8407a052e79fdbab18f7f4f0579c6453402
frankyvij commented 3 years ago

Hello @xiprox , the above commit does not seem to work. There are a lot of missing arguments, and extra arguments error after using your change.

Below is a small example, but there are 100s of errors.

/Users/frankyvij/development/flutter/.pub-cache/git/admob_flutter-ca12b8407a052e79fdbab18f7f4f0579c6453402/ios/Classes/AdmobInterstitialPlugin.swift:99:39: error: cannot find 'GADInterstitial' in scope let interstantialAd = GADInterstitial(adUnitID: interstantialAdUnitId)

penguru commented 3 years ago

Same here, @xiprox any update?

armandojimenez commented 3 years ago

I had to completely move to google official ad package because of this, and also seems this package is not maintained anymore

penguru commented 3 years ago

Same here, I gave up.. I will continue with https://pub.dev/packages/google_mobile_ads, event it's beta..

FernandoUFS commented 3 years ago

I did the same thing

Same here, I gave up.. I will continue with https://pub.dev/packages/google_mobile_ads, event it's beta..

kmcgill88 commented 3 years ago

Same here, I gave up.. I will continue with https://pub.dev/packages/google_mobile_ads, event it's beta..

That package is the future anyway. No way I can keep up this side project vs a google sponsored package. I'm planning on sunsetting this package and support that one in the near future.

efraespada commented 3 years ago

@loicgeek I stopped using this plugin and moved to native_admob_flutter. Basically is the same plugin.. 😕