kmdlogic / kmd-logic-audit-client

A dotnet client library for the KMD Logic Audit service
MIT License
0 stars 4 forks source link

The config objects passed to client ctor should be immutable #9

Open adamchester opened 5 years ago

adamchester commented 5 years ago

As they are now, it's potentially confusing to consumers of the clients because it looks like they might be able to change them after construction, and perhaps have those changed values reflected in future events raised (e.g. changing event source).

However, if those objects passed in were immutable, it would be clear they can't be changed (which they cannot at this time, the clients are meant to be configured only once at instance creation).

adamchester commented 5 years ago

cc @Araballi