search

kmehan / gt-course-critique

Georgia Institute of Technology Course Critique
18 stars 13 forks source link

Format changes to README #23

Closed chrisforrence closed 10 years ago

chrisforrence commented 10 years ago

Improving the display of the README file with list format and header formatting for Georgia Institute of Technology Course Critique.

Also splitting out the easter egg code into its own file (so we can include it if wanted or leave it out for bandwidth)

chrisforrence commented 10 years ago

@saiarcot895 I did switch the if-statements around (to put error/problems first). Not sure which file you mean, though; are you referring to the OGG/MP3, or the agents? In either case, I'm not sure it'll mean much in the grand scheme of things to optimize those (especially this code would likely not be called frequently)

saiarcot895 commented 10 years ago

@chrisforrence I meant the OGG/MP3 blocks. (I should have added the line number range.)

chrisforrence commented 10 years ago

@saiarcot895 Ah, I see what you mean. I'm not as worried about it; the file size difference between the two is less than 100 bytes, it's a low chance the code gets executed, and the MP3 format has a higher likelihood of being supported in available browsers (IE+Chrome+Safari+Firefox vs Chrome+Firefox+Opera). If you'd like to switch them, feel free to make a pull request against my branch, and I'll merge it in