search

kmehan / gt-course-critique

Georgia Institute of Technology Course Critique
18 stars 13 forks source link

Update index.html #32

Closed RussellRollins closed 10 years ago

RussellRollins commented 10 years ago

You should load the jquery from a secure cdn. Changed to https. Chrome won't load jquery if you load it from http. This fixed the issue on my local machine

chrisforrence commented 10 years ago

Mmm, it's not quite the correct way to do it; while you're right, it's better to use a protocol-relative URI since Course Critique is served over HTTP and HTTPS. At that point, the code would look like this:

<script src="//cdn.path.example.com/jquery.min.js"></script>

Also as a heads up, we're working on getting access to the new SGA IT director, so it may be a little bit before changes are merged (see Issue #31)

Thank you for contributing to Course Critique!

chrisforrence commented 10 years ago

And it appears we have a local copy of jquery in 'js/jquery.min.js'; it may be more reliable to reference the CDN but use the local copy if the CDN is unavailable.