kmesh-net / kmesh

High Performance ServiceMesh Data Plane Based on eBPF and Programmable Kernel
https://kmesh.net
Apache License 2.0
467 stars 70 forks source link

Keep one Kube client create function #1043

Closed hzxuzhonghu closed 1 week ago

hzxuzhonghu commented 1 week ago

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 5.00000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 48.09%. Comparing base (edc7c5e) to head (a6a6bb2). Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
pkg/kube/kubeclient.go 0.00% 16 Missing :warning:
pkg/bpf/restart/bpf_restart.go 0.00% 1 Missing :warning:
pkg/cni/plugin/plugin.go 0.00% 1 Missing :warning:
pkg/controller/controller.go 0.00% 1 Missing :warning:
Files with missing lines Coverage Δ
pkg/controller/config/config.go 60.00% <100.00%> (ø)
pkg/kube/informer.go 100.00% <ø> (ø)
pkg/bpf/restart/bpf_restart.go 44.89% <0.00%> (+0.89%) :arrow_up:
pkg/cni/plugin/plugin.go 0.00% <0.00%> (ø)
pkg/controller/controller.go 0.00% <0.00%> (ø)
pkg/kube/kubeclient.go 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cb05690...a6a6bb2. Read the comment docs.

LiZhenCheng9527 commented 1 week ago

/lgtm /approve

kmesh-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiZhenCheng9527

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/OWNERS](https://github.com/kmesh-net/kmesh/blob/main/pkg/OWNERS)~~ [LiZhenCheng9527] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment