kmesh-net / kmesh

High Performance ServiceMesh Data Plane Based on Programmable Kernel
https://kmesh.net
Apache License 2.0
466 stars 70 forks source link

kmeshctl dump failed issue resolve #1045

Closed codesmith25103 closed 4 days ago

codesmith25103 commented 1 week ago

What type of PR is this? Kmesh mode has been successfully renamed from ads & workload to kernel-native & dual-engine

What this PR does / why we need it:

Which issue(s) this PR fixes: Fixes #1016

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.09%. Comparing base (4100c52) to head (fddd2b3). Report is 83 commits behind head on main.

Files with missing lines Coverage Δ
pkg/status/status_server.go 38.85% <ø> (+0.09%) :arrow_up:

... and 21 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6adf575...fddd2b3. Read the comment docs.

kmesh-bot commented 5 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/status/OWNERS](https://github.com/kmesh-net/kmesh/blob/main/pkg/status/OWNERS)~~ [hzxuzhonghu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
hzxuzhonghu commented 4 days ago

/lgtm