search

kmesh-net / kmesh

High Performance ServiceMesh Data Plane Based on Programmable Kernel
https://kmesh.net
Apache License 2.0
466 stars 70 forks source link

Correct Workload handle order #1047

Open hzxuzhonghu opened 4 days ago

hzxuzhonghu commented 4 days ago

What type of PR is this?

What this PR does / why we need it:

No matter workload/service update, we should make sure bpf map is updated in the following orders:

backendmap-> endpoint map -> service map -> frontend map

In case workload/service delete, the order should be as below:

frontend map-> service map -> endpoint map -> backend map

Which issue(s) this PR fixes: Fixes #1042

And made many cleanups

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

kmesh-bot commented 4 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from hzxuzhonghu. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[pkg/controller/OWNERS](https://github.com/kmesh-net/kmesh/blob/main/pkg/controller/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 54.83871% with 56 lines in your changes missing coverage. Please review.

Project coverage is 50.38%. Comparing base (6bb2ae0) to head (c25406c). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/workload/workload_processor.go 57.01% 32 Missing and 17 partials :warning:
pkg/controller/workload/cache/endpoint_cache.go 0.00% 7 Missing :warning:
Files with missing lines Coverage Δ
pkg/controller/workload/bpfcache/endpoint.go 60.37% <100.00%> (+60.37%) :arrow_up:
pkg/controller/workload/cache/endpoint_cache.go 70.58% <0.00%> (-18.31%) :arrow_down:
pkg/controller/workload/workload_processor.go 61.90% <57.01%> (-0.34%) :arrow_down:

... and 4 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 288f6fa...c25406c. Read the comment docs.

🚨 Try these New Features: