kmesh-net / kmesh

High Performance ServiceMesh Data Plane Based on eBPF and Programmable Kernel
https://kmesh.net
Apache License 2.0
467 stars 70 forks source link

Improvement of metriclabels removal capability at workload granularity #1055

Closed LiZhenCheng9527 closed 1 day ago

LiZhenCheng9527 commented 1 week ago

What type of PR is this? /kind enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes a part of #1033

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 65.21739% with 8 lines in your changes missing coverage. Please review.

Project coverage is 48.93%. Comparing base (de98f8b) to head (90405e0). Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/telemetry/metric.go 66.66% 2 Missing and 2 partials :warning:
pkg/controller/telemetry/utils.go 63.63% 4 Missing :warning:
Files with missing lines Coverage Δ
pkg/controller/telemetry/metric.go 55.40% <66.66%> (+0.47%) :arrow_up:
pkg/controller/telemetry/utils.go 64.61% <63.63%> (-0.20%) :arrow_down:

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dbe34d1...90405e0. Read the comment docs.


🚨 Try these New Features:

kmesh-bot commented 1 day ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/controller/OWNERS](https://github.com/kmesh-net/kmesh/blob/main/pkg/controller/OWNERS)~~ [hzxuzhonghu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment