search

kmesh-net / kmesh

High Performance ServiceMesh Data Plane Based on Programmable Kernel
https://kmesh.net
Apache License 2.0
424 stars 59 forks source link

chore: add kmesh-system namespace api object in kmesh.yaml #334

Closed Okabe-Rintarou-0 closed 4 months ago

Okabe-Rintarou-0 commented 4 months ago

What type of PR is this? enhancement

What this PR does / why we need it: add kmesh-system namespace so that installing kmesh from yaml files won't raise a namespace-not-found error.

plz see another pr https://github.com/kmesh-net/website/pull/40

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

kmesh-bot commented 4 months ago

Welcome @Okabe-Rintarou-0! It looks like this is your first PR to kmesh-net/kmesh 🎉

nlgwcy commented 4 months ago

Pls update the PR description~

LiZhenCheng9527 commented 4 months ago

/lgtm

nlgwcy commented 4 months ago

/lgtm /approve

kmesh-bot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nlgwcy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kmesh-net/kmesh/blob/main/OWNERS)~~ [nlgwcy] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment