search

kmesh-net / kmesh

High Performance ServiceMesh Data Plane Based on Programmable Kernel
https://kmesh.net
Apache License 2.0
424 stars 59 forks source link

fix: should get authz policy from dst-worklod when rbac #336

Closed supercharge-xsy closed 4 months ago

supercharge-xsy commented 4 months ago

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

supercharge-xsy commented 4 months ago

/retest

tacslon commented 4 months ago

/lgtm

supercharge-xsy commented 4 months ago

@nlgwcy @hzxuzhonghu

supercharge-xsy commented 4 months ago

I am wondering how it works when we tested

because another issue， we update by_namespace store when apply a workload-select policy, it will leader that the policy makes effect when client and server in a same namspace; that issue fix by: https://github.com/kmesh-net/kmesh/pull/333

kmesh-bot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/auth/OWNERS](https://github.com/kmesh-net/kmesh/blob/main/pkg/auth/OWNERS)~~ [hzxuzhonghu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
hzxuzhonghu commented 4 months ago

/lgtm