search

kmesh-net / kmesh

High Performance ServiceMesh Data Plane Based on Programmable Kernel
https://kmesh.net
Apache License 2.0
362 stars 46 forks source link

backend_manager can return 1 from tail call, so check negative value #359

Open hzxuzhonghu opened 1 month ago

hzxuzhonghu commented 1 month ago

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes: Fix https://github.com/kmesh-net/kmesh/issues/355

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

kmesh-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from hzxuzhonghu. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kmesh-net/kmesh/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
hzxuzhonghu commented 1 month ago

Wa are not sure how the 1 was returned, and could not reproduce with latest code