Closed bfforever closed 1 month ago
Attention: Patch coverage is 0%
with 2 lines
in your changes are missing coverage. Please review.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Flag | Coverage Δ | |
---|---|---|
unittests | 31.64% <0.00%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files | Coverage Δ | |
---|---|---|
pkg/controller/controller.go | 0.00% <0.00%> (ø) |
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hzxuzhonghu
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What type of PR is this? /kind feature
What this PR does / why we need it: Improve ipaddr format of bpf log. And Fix xdsClient workloadController nil pointer bug when Kmesh mode is Ads.
Which issue(s) this PR fixes: Fixes 358
Special notes for your reviewer:
In ads mode:![bpf_log_1](https://github.com/kmesh-net/kmesh/assets/39798612/0360bc30-2c0b-4f18-8fcc-99d2609d2e1f)
In workload mode:![bpf_log_2](https://github.com/kmesh-net/kmesh/assets/39798612/3ee7e829-8b66-47b8-86d5-c887d022da73)
Does this PR introduce a user-facing change?: