kmesh-net / kmesh

High Performance ServiceMesh Data Plane Based on Programmable Kernel
https://kmesh.net
Apache License 2.0
362 stars 46 forks source link

Fix cleanup kmesh-cni failed bug #367

Closed bfforever closed 1 month ago

bfforever commented 1 month ago

What type of PR is this? /kind bug

What this PR does / why we need it: Fix cleanup kmesh-cni failed bug.

Which issue(s) this PR fixes: Fixes #365

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Flag Coverage Δ
unittests 31.67% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/cni/chained.go 38.25% <0.00%> (ø)
pkg/cni/install.go 20.00% <0.00%> (ø)
hzxuzhonghu commented 1 month ago

/lgtm

/approve

kmesh-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kmesh-net/kmesh/blob/main/OWNERS)~~ [hzxuzhonghu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
hzxuzhonghu commented 1 month ago

@bfforever Yare qualified to apply member https://github.com/kmesh-net/kmesh/issues/new?assignees=&labels=&projects=&template=membership-request.md&title=REQUEST%3A+New+membership+for+%3Cyour+name%3E