kmesh-net / kmesh

High Performance ServiceMesh Data Plane Based on Programmable Kernel
https://kmesh.net
Apache License 2.0
362 stars 46 forks source link

Improve isManagedWorkload #368

Closed hzxuzhonghu closed 1 month ago

hzxuzhonghu commented 1 month ago

This is adding check node name

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 17.07317% with 34 lines in your changes are missing coverage. Please review.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Flag Coverage Δ
unittests 31.18% <17.07%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/controller/client.go 65.11% <100.00%> (ø)
pkg/controller/workload/cache/workload_cache.go 77.27% <66.66%> (ø)
pkg/controller/security/manager.go 0.00% <0.00%> (ø)
pkg/auth/rbac.go 59.51% <20.00%> (ø)
pkg/controller/workload/workload_processor.go 13.72% <3.84%> (ø)
hzxuzhonghu commented 1 month ago

@supercharge-xsy any other comments

supercharge-xsy commented 1 month ago

/lgtm /approve

kmesh-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: supercharge-xsy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/auth/OWNERS](https://github.com/kmesh-net/kmesh/blob/main/pkg/auth/OWNERS)~~ [supercharge-xsy] - ~~[pkg/controller/OWNERS](https://github.com/kmesh-net/kmesh/blob/main/pkg/controller/OWNERS)~~ [supercharge-xsy] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment