search

kmesh-net / kmesh

High Performance ServiceMesh Data Plane Based on Programmable Kernel
https://kmesh.net
Apache License 2.0
362 stars 46 forks source link

optimization for kmesh build slow #382

Closed bfforever closed 1 month ago

bfforever commented 1 month ago

What type of PR is this? /kind feature

What this PR does / why we need it: when build with make docker, build is slow, especially in development of Kmesh.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Flag Coverage Δ
unittests 31.21% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

hzxuzhonghu commented 1 month ago

/lgtm

/approve

bfforever commented 1 month ago

/lgtm

/approve

@hzxuzhonghu I had changed kmesh.dockerfile, put the RUN \ --mount=type=cache,target=/var/cache/dnf \ yum install -y kmod util-linux iptables in advanced line, to make use of build cache, avoid every build time downloading yum dependence files when changes happen in below command ADD out/$arch/*so* /usr/lib64/ ADD out/$arch/kmesh-daemon /usr/bin/ and etc.

kmesh-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kmesh-net/kmesh/blob/main/OWNERS)~~ [hzxuzhonghu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment