search

kmesh-net / kmesh

High Performance ServiceMesh Data Plane Based on Programmable Kernel
https://kmesh.net
Apache License 2.0
362 stars 46 forks source link

support identity rbac #400

Closed supercharge-xsy closed 4 weeks ago

supercharge-xsy commented 1 month ago

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes: Fixes #https://github.com/kmesh-net/kmesh/issues/323

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

supercharge-xsy commented 1 month ago

/hold

supercharge-xsy commented 4 weeks ago

/unhold

codecov-commenter commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Flag Coverage Δ
unittests 31.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/auth/rbac.go 56.75% <0.00%> (ø)
kmesh-bot commented 4 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/auth/OWNERS](https://github.com/kmesh-net/kmesh/blob/main/pkg/auth/OWNERS)~~ [hzxuzhonghu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
hzxuzhonghu commented 4 weeks ago

/lgtm