kmesh-net / kmesh

High Performance ServiceMesh Data Plane Based on Programmable Kernel
https://kmesh.net
Apache License 2.0
362 stars 46 forks source link

Simplify byteorder transformation & remove magic number in Authz #407

Closed tacslon closed 1 week ago

tacslon commented 1 month ago

What type of PR is this? /kind enhancement

What this PR does / why we need it:

  1. Clarify byteorder transformation in Authz
  2. Remove magic number in Authz Which issue(s) this PR fixes: Fixes #323

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 44 lines in your changes missing coverage. Please review.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Flag Coverage Δ
unittests 37.16% <0.00%> (+5.14%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/auth/xdp_auth_handler.go 0.00% <0.00%> (ø)
pkg/auth/rbac.go 57.42% <0.00%> (+0.66%) :arrow_up:

... and 6 files with indirect coverage changes

tacslon commented 4 weeks ago

/hold

tacslon commented 4 weeks ago

/unhold

hzxuzhonghu commented 2 weeks ago

Please add some unit tests

kmesh-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/auth/OWNERS](https://github.com/kmesh-net/kmesh/blob/main/pkg/auth/OWNERS)~~ [hzxuzhonghu] - ~~[pkg/controller/OWNERS](https://github.com/kmesh-net/kmesh/blob/main/pkg/controller/OWNERS)~~ [hzxuzhonghu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment