Fix bug when delete waypoint, dont update bpf kmesh_service map

kmesh-net / kmesh

High Performance ServiceMesh Data Plane Based on Programmable Kernel

https://kmesh.net

Apache License 2.0

361 stars 46 forks source link

Fix bug when delete waypoint, dont update bpf kmesh_service map #420

Closed bfforever closed 3 weeks ago

bfforever commented 3 weeks ago

What type of PR is this? /kind bug

What this PR does / why we need it: In istio 1.22.1, when delete a waypoint, which proxy for a certain k8s service, the workload_processor don't update kmesh_service bpf map, end up to still route to the old waypoint.

Which issue(s) this PR fixes: Fixes #406

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

codecov-commenter commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Flag	Coverage Δ
unittests	`31.75% <0.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
pkg/controller/workload/workload_processor.go	`13.39% <0.00%> (ø)`

bfforever commented 3 weeks ago

/hold

kmesh-bot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment