search

kmesh-net / kmesh

High Performance ServiceMesh Data Plane Based on Programmable Kernel
https://kmesh.net
Apache License 2.0
361 stars 46 forks source link

Fix authPolicy remove #435

Closed hzxuzhonghu closed 1 week ago

hzxuzhonghu commented 2 weeks ago

What type of PR is this?

What this PR does / why we need it:

Fix the issue: a authorization deleted, the same namespace scoped authorization will be mis removed

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

supercharge-xsy commented 2 weeks ago

The modification is fine, but seems that the test case needs to be modified accordingly.

tacslon commented 1 week ago

/lgtm

supercharge-xsy commented 1 week ago

/lgtm /approve

kmesh-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: supercharge-xsy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kmesh-net/kmesh/blob/main/OWNERS)~~ [supercharge-xsy] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment