kmesh-net / kmesh

High Performance ServiceMesh Data Plane Based on Programmable Kernel
https://kmesh.net
Apache License 2.0
361 stars 46 forks source link

Bug fix on xds handler #438

Closed hzxuzhonghu closed 1 week ago

hzxuzhonghu commented 1 week ago

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes https://github.com/kmesh-net/kmesh/issues/437 Fixes https://github.com/kmesh-net/kmesh/issues/440

  1. Fix cluster leak after service deleted
  2. Fix route leak after service deleted
  3. And fix missing subscribe eds after reconnect

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Flag Coverage Δ
unittests 37.17% <100.00%> (+5.16%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/controller/ads/ads_processor.go 80.45% <100.00%> (+0.94%) :arrow_up:

... and 6 files with indirect coverage changes

nlgwcy commented 1 week ago

/lgtm /approve

kmesh-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nlgwcy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kmesh-net/kmesh/blob/main/OWNERS)~~ [nlgwcy] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment