search

kmesh-net / kmesh

High Performance ServiceMesh Data Plane Based on Programmable Kernel
https://kmesh.net
Apache License 2.0
361 stars 46 forks source link

Support dynamic changing log level in status manager #446

Closed Okabe-Rintarou-0 closed 1 week ago

Okabe-Rintarou-0 commented 1 week ago

What type of PR is this? feature

What this PR does / why we need it: Support dynamic changing log level in status manager Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Okabe-Rintarou-0 commented 1 week ago

Example:

image

Okabe-Rintarou-0 commented 1 week ago

maybe we can also add some shortcuts in command, like:

hzxuzhonghu commented 1 week ago

maybe we can also add some shortcuts in command, like:

kmesh-daemon logs: print logs kmesh-daemon logger --name default --set level=info: set the specified logger's level

How about kmesh-daemon log --set default:debug, if no --set specified, treat it as get log level

Okabe-Rintarou-0 commented 1 week ago

maybe we can also add some shortcuts in command, like: kmesh-daemon logs: print logs kmesh-daemon logger --name default --set level=info: set the specified logger's level

How about kmesh-daemon log --set default:debug, if no --set specified, treat it as get log level

yes, it'd be better. I will work on it.

kmesh-bot commented 1 week ago

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository. Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kmesh-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kmesh-net/kmesh/blob/main/OWNERS)~~ [hzxuzhonghu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
hzxuzhonghu commented 1 week ago

/lgtm

Please support the subcmd in a following up pr

hzxuzhonghu commented 1 week ago

should remove the merge commit