Fix argument list too long in manage controller

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.16%. Comparing base (764f121) to head (fdca0a7). Report is 28 commits behind head on main.

Files with missing lines	Coverage Δ
pkg/controller/manage/manage_controller.go	`55.06% <100.00%> (-0.74%)`	:arrow_down:
pkg/utils/enroll.go	`94.44% <100.00%> (+0.21%)`	:arrow_up:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c9634e1...fdca0a7. Read the comment docs.

tacslon commented 3 months ago

An alternatrive maybe make these functions as a method of KmeshManageController, tehn you donot need to pass these args

This seems to be more reasonable, please make a review @hzxuzhonghu

tacslon commented 1 month ago

@hzxuzhonghu Please review

kmesh-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/OWNERS](https://github.com/kmesh-net/kmesh/blob/main/pkg/OWNERS)~~ [hzxuzhonghu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kmesh-net / kmesh

Fix argument list too long in manage controller #711

Codecov Report