kmesh-net / kmesh

High Performance ServiceMesh Data Plane Based on Programmable Kernel
https://kmesh.net
Apache License 2.0
464 stars 70 forks source link

make bypass idempotent #731

Closed weli-l closed 3 months ago

weli-l commented 3 months ago

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes: Fixes #637

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Project coverage is 51.67%. Comparing base (b60c13c) to head (f62f5fa). Report is 15 commits behind head on main.

Files Patch % Lines
pkg/controller/bypass/bypass_controller.go 16.66% 5 Missing :warning:
Files Coverage Δ
pkg/controller/manage/manage_controller.go 54.46% <100.00%> (-0.80%) :arrow_down:
pkg/kube/informer.go 100.00% <100.00%> (ø)
pkg/utils/exec.go 0.00% <ø> (ø)
pkg/controller/bypass/bypass_controller.go 34.09% <16.66%> (-4.99%) :arrow_down:

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 077928f...f62f5fa. Read the comment docs.

kmesh-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kmesh-net/kmesh/blob/main/OWNERS)~~ [hzxuzhonghu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment