search

kmesh-net / kmesh

High Performance ServiceMesh Data Plane Based on Programmable Kernel
https://kmesh.net
Apache License 2.0
459 stars 69 forks source link

TestHandleKmeshManage/10._ns_without_label,_pod_ready_add_without_annotation flake #879

Open Okabe-Rintarou-0 opened 1 month ago

Okabe-Rintarou-0 commented 1 month ago

What happened:

=== NAME  TestHandleKmeshManage/10._ns_without_label,_pod_ready_add_without_annotation
    manage_controller_test.go:186: 
            Error Trace:    /home/runner/work/kmesh/kmesh/pkg/controller/manage/manage_controller_test.go:186
                                        /home/runner/work/kmesh/kmesh/pkg/controller/manage/manage_controller_test.go:425
            Error:          Not equal: 
                            expected: false
                            actual  : true
            Test:           TestHandleKmeshManage/10._ns_without_label,_pod_ready_add_without_annotation
            Messages:       unexpected value for disabled flag
--- FAIL: TestHandleKmeshManage (30.25s)
    --- PASS: TestHandleKmeshManage/1._ns_without_label,_pod_without_label (0.01s)
    --- PASS: TestHandleKmeshManage/2._ns_without_label,_pod_update_with_label (0.01s)
    --- PASS: TestHandleKmeshManage/2.1_ns_without_label,_pod_update_with_`none`_label (0.04s)
    --- PASS: TestHandleKmeshManage/3._ns_without_label,_pod_with_none_label_delete (0.01s)
    --- PASS: TestHandleKmeshManage/4._ns_without_label,_pod_with_label (0.02s)
    --- PASS: TestHandleKmeshManage/4.1_ns_without_label,_pod_with_label_delete (0.01s)
    --- PASS: TestHandleKmeshManage/5._ns_with_label,_pod_without_label (0.02s)
    --- PASS: TestHandleKmeshManage/6._ns_with_label,_pod_update_with_label (0.01s)
    --- PASS: TestHandleKmeshManage/7._ns_with_label,_pod_update_with_none_label (0.02s)
    --- PASS: TestHandleKmeshManage/8._ns_with_label,_pod_delete_with_none_label (0.01s)
    --- PASS: TestHandleKmeshManage/9._ns_without_label,_pod_is_not_ready_with_label (0.01s)
    --- PASS: TestHandleKmeshManage/9.1._ns_without_label,_pod_is_not_ready_update_without_label (0.01s)
    --- FAIL: TestHandleKmeshManage/10._ns_without_label,_pod_ready_add_without_annotation (30.01s)

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

Okabe-Rintarou-0 commented 1 month ago

maybe due to this: https://github.com/kmesh-net/kmesh/blob/cce29bcdc8e709d53d8c08d66bbe9875c40b0453/pkg/controller/manage/manage_controller_test.go#L399-L400

Okabe-Rintarou-0 commented 1 month ago

/assign

hzxuzhonghu commented 1 month ago

@Okabe-Rintarou-0 i have seen this recently again, can you reproduce locally