kmesh-net / kmesh

High Performance ServiceMesh Data Plane Based on Programmable Kernel
https://kmesh.net
Apache License 2.0
446 stars 63 forks source link

Running e2e tests requires root permissions #930

Open tjons opened 2 weeks ago

tjons commented 2 weeks ago

What happened: When running make e2e, the e2e test script attempts to move the istioctl binary to the /usr/local/bin directory: https://github.com/kmesh-net/kmesh/blob/main/test/e2e/run_test.sh#L187. This causes the script to fail without permission to write to the /usr/local/bin directory.

What you expected to happen: The tests should install dependencies into a temporary directory within the project, and remove the dependencies upon successful completion of the tests.

How to reproduce it (as minimally and precisely as possible): make e2e without having write permissions to the /usr/local/bin directory.

Anything else we need to know?: N/A

Environment:

hzxuzhonghu commented 2 weeks ago

cc @YaoZengzeng to have a look

YaoZengzeng commented 1 day ago

/assign